cannot compile with c++builder xe/xe2

[Mihai Oltean]

Hi there,

I'm trying to compile the libraries (version 3.0.1) with embarcadero (ex
borland) compiler and I get an error:

Error E2352 ..\..\src\common\appbase.cpp 320: Cannot create instance of
abstract
class 'wxAppTraits' in function wxAppConsoleBase::GetValidTraits()
Error E2353 ..\..\src\common\appbase.cpp 320: Class 'wxAppTraits' is
abstract be
cause of 'wxAppTraits::BeforeChildWaitLoop() = 0' in function
wxAppConsoleBase::
GetValidTraits()
*** 2 errors in Compile ***

** error 2 ** deleting bcc_mswud\baselib_appbase.obj

can somebody help me?

thanks,
mihai

[Vadim Zeitlin]

On Sun, 24 Aug 2014 10:56:58 -0700 (PDT) Mihai Oltean wrote:

MO> I'm trying to compile the libraries (version 3.0.1) with embarcadero (ex
MO> borland) compiler

I'm afraid nobody has tested wx3 with Borland compiler. It's just not
popular enough nowadays, and while I'd welcome any fixes for it, I don't
think we can promise any kind of support for it without help from its
users.

MO> and I get an error:
MO>
MO> Error E2352 ..\..\src\common\appbase.cpp 320: Cannot create instance of
MO> abstract
MO> class 'wxAppTraits' in function wxAppConsoleBase::GetValidTraits()
MO> Error E2353 ..\..\src\common\appbase.cpp 320: Class 'wxAppTraits' is
MO> abstract be
MO> cause of 'wxAppTraits::BeforeChildWaitLoop() = 0' in function
MO> wxAppConsoleBase::
MO> GetValidTraits()
MO> *** 2 errors in Compile ***
MO>
MO> ** error 2 ** deleting bcc_mswud\baselib_appbase.obj
MO>
MO> can somebody help me?

This looks like a bug due to missing -D__WIN32__ in BASELIB_CXXFLAGS in
makefile.bcc, so the correct header is not included in wx/apptrait.h. It
should be easy to fix if you can try but, again, personally I don't have
this compiler and can't help much with it.

Good luck,
VZ

[Mihai Oltean]

thanks Vadim,

which was the last version of bcb that was used for compiling wxWidgets 3?
I also have c++builder 6 ...

anyway, I have added that flag and I still get the error:

BASELIB_CXXFLAGS = -D__WIN32__ $(__RUNTIME_LIBS) -I$(BCCDIR)\include
$(__DEBUGINFO) \
.....
///////////////////////////////////////
bcc32 -q -c -P -obcc_mswud\baselib_appbase.obj -D__WIN32__ -tWR
-I"c:\Pr
ogram Files (x86)\Embarcadero\RAD Studio\9.0"\include -v -Od -tWM
-D__WXMSW__
-D_UNICODE -I..\..\lib\bcc_lib\mswud -I..\..\include
-DWXBUILDIN
G -I..\..\src\tiff\libtiff -I..\..\src\jpeg -I..\..\src\png
-I..\..\src\zlib -
I..\..\src\regex -I..\..\src\expat\lib -DwxUSE_GUI=0 -DwxUSE_BASE=1 -Hu
-H=b
cc_mswud\wxprec_baselib.csm -a8 -g0 ..\..\src\common\appbase.cpp
..\..\src\common\appbase.cpp:
Error E2352 ..\..\src\common\appbase.cpp 320: Cannot create instance of
abstract
class 'wxAppTraits' in function wxAppConsoleBase::GetValidTraits()
Error E2353 ..\..\src\common\appbase.cpp 320: Class 'wxAppTraits' is
abstract be
cause of 'wxAppTraits::BeforeChildWaitLoop() = 0' in function
wxAppConsoleBase::
GetValidTraits()
*** 2 errors in Compile ***

thanks,
mihai

Post by Vadim Zeitlin
MO> I'm trying to compile the libraries (version 3.0.1) with embarcadero (ex
MO> borland) compiler
I'm afraid nobody has tested wx3 with Borland compiler. It's just not
popular enough nowadays, and while I'd welcome any fixes for it, I don't
think we can promise any kind of support for it without help from its
users.
MO>
MO> Error E2352 ..\..\src\common\appbase.cpp 320: Cannot create instance of
MO> abstract
MO> class 'wxAppTraits' in function wxAppConsoleBase::GetValidTraits()
MO> Error E2353 ..\..\src\common\appbase.cpp 320: Class 'wxAppTraits' is
MO> abstract be
MO> cause of 'wxAppTraits::BeforeChildWaitLoop() = 0' in function
MO> GetValidTraits()
MO> *** 2 errors in Compile ***
MO>
MO> ** error 2 ** deleting bcc_mswud\baselib_appbase.obj
MO>
MO> can somebody help me?
This looks like a bug due to missing -D__WIN32__ in BASELIB_CXXFLAGS in
makefile.bcc, so the correct header is not included in wx/apptrait.h. It
should be easy to fix if you can try but, again, personally I don't have
this compiler and can't help much with it.
Good luck,
VZ
--
TT-Solutions: wxWidgets consultancy and technical support
http://www.tt-solutions.com/

[Vadim Zeitlin]

On Sun, 24 Aug 2014 12:46:56 -0700 (PDT) Mihai Oltean wrote:

MO> which was the last version of bcb that was used for compiling wxWidgets 3?

I don't think anybody tested the final version with Borland.

MO> I also have c++builder 6 ...

http://wiki.wxwidgets.org/Supported_Platforms says that r66666 built with
it but this was ~3.5 years ago...

MO> anyway, I have added that flag and I still get the error:
MO>
MO> BASELIB_CXXFLAGS = -D__WIN32__ $(__RUNTIME_LIBS) -I$(BCCDIR)\include
MO> $(__DEBUGINFO) \
MO> .....
MO> ///////////////////////////////////////
MO> bcc32 -q -c -P -obcc_mswud\baselib_appbase.obj -D__WIN32__ -tWR
MO> -I"c:\Pr
MO> ogram Files (x86)\Embarcadero\RAD Studio\9.0"\include -v -Od -tWM
MO> -D__WXMSW__
MO> -D_UNICODE -I..\..\lib\bcc_lib\mswud -I..\..\include
MO> -DWXBUILDIN
MO> G -I..\..\src\tiff\libtiff -I..\..\src\jpeg -I..\..\src\png
MO> -I..\..\src\zlib -
MO> I..\..\src\regex -I..\..\src\expat\lib -DwxUSE_GUI=0 -DwxUSE_BASE=1 -Hu
MO> -H=b
MO> cc_mswud\wxprec_baselib.csm -a8 -g0 ..\..\src\common\appbase.cpp
MO> ..\..\src\common\appbase.cpp:
MO> Error E2352 ..\..\src\common\appbase.cpp 320: Cannot create instance of
MO> abstract
MO> class 'wxAppTraits' in function wxAppConsoleBase::GetValidTraits()
MO> Error E2353 ..\..\src\common\appbase.cpp 320: Class 'wxAppTraits' is
MO> abstract be
MO> cause of 'wxAppTraits::BeforeChildWaitLoop() = 0' in function
MO> wxAppConsoleBase::
MO> GetValidTraits()
MO> *** 2 errors in Compile ***

Sorry, I don't see what is going on here then. My initial understanding of
the problem was that the correct header wasn't included in wx/apptrait.h
because __WIN32__ was not defined. If it is included, wxConsoleAppTraits
should be defined in wx/msw/apptrait.h where BeforeChildWaitLoop() is
declared, so it shouldn't result in this error.

You need to debug what's going on here, e.g. by inserting #errors in
various places and checking whether you're compiling the code you think you
compile.

Also, have you cleaned everything, especially the precompiled headers
(*.csm?) before testing this?

Good luck,
VZ

[Никита Ушаков]

Post by Vadim Zeitlin
Sorry, I don't see what is going on here then. My initial understanding of
the problem was that the correct header wasn't included in wx/apptrait.h
because __WIN32__ was not defined. If it is included, wxConsoleAppTraits
should be defined in wx/msw/apptrait.h where BeforeChildWaitLoop() is
declared, so it shouldn't result in this error.
__WIN32__ nothing to do with. Everything is included correctly.

Please note the following remark
Class 'wxAppTraits' is abstract be cause of
'wxAppTraits::BeforeChildWaitLoop() = 0'
Maybe would be to declare
'wxAppTraits::BeforeChildWaitLoop()'

[Никита Ушаков]

Post by Никита Ушаков
Maybe would be to declare
'wxAppTraits::BeforeChildWaitLoop()'

rather
virtual void *BeforeChildWaitLoop() { return NULL; }

[David Connet]

That would be wrong since wxAppTraits is _supposed_ to be a pure abstract class.

________________________________
Sent: Sunday, September 21, 2014 7:53 AM
Subject: Re: Re[2]: cannot compile with c++builder xe/xe2
Maybe would be to declare

'wxAppTraits:: BeforeChildWaitLoop()'

rather
virtual void *BeforeChildWaitLoop() { return NULL; }

[Vadim Zeitlin]

On Sun, 21 Sep 2014 15:54:39 -0700 David Connet wrote:

DC> That would be wrong since wxAppTraits is supposed to be a pure abstract class.

Exactly. The real problem is that the correct declarations of
wxConsoleAppTraits and/or wxGUIAppTraits from wx/msw/apptrait.h are not
being used in your build somehow. You need to understand why does this
happen and fix this, providing the dummy implementation of this method
might make the rest compile (although I'm not even sure about it), but it
definitely won't make the code *work* correctly.

Regards,
VZ

[Никита Ушаков]

/* static */
wxAppTraits& wxAppConsoleBase::GetValidTraits()
{
static wxConsoleAppTraits s_traitsConsole;

// wxAppTraits* const traits = wxTheApp ? wxTheApp->GetTraits() : NULL;
wxAppTraits* const traits = (wxTheApp ? wxTheApp->GetTraits() : NULL);

//return traits ? *traits : s_traitsConsole;
if (traits) return *traits; else return s_traitsConsole;
}
So the concept is not broken?
*work* - in the sense compiles.

Next error
Error E2015 ..\..\src\common\filename.cpp 2589: Ambiguity between
'wxFileName::Exists(int)
const at ..\..\src\common\filename.cpp:777' and 'wxFileName::Exists(const
wxString &,int)
at ..\..\src\common\filename.cpp:790' in function
wxFileName::SetPermissions(int)

[Vadim Zeitlin]

On Tue, 23 Sep 2014 08:11:30 -0700 (PDT) НОкОта УшакПв wrote:

НУ> /* static */
НУ> wxAppTraits& wxAppConsoleBase::GetValidTraits()
НУ> {
НУ> static wxConsoleAppTraits s_traitsConsole;
НУ>
НУ> // wxAppTraits* const traits = wxTheApp ? wxTheApp->GetTraits() : NULL;
НУ> wxAppTraits* const traits = (wxTheApp ? wxTheApp->GetTraits() : NULL);
НУ>
НУ> //return traits ? *traits : s_traitsConsole;
НУ> if (traits) return *traits; else return s_traitsConsole;
НУ> }
НУ> So the concept is not broken?
НУ> work - in the sense compiles.

Ah, so the real problem is with the use of the ternary operator, is that
it? It's amazing that Borland still continues to be broken with its
handling of operator ?: up to this day... I wonder if

return *(traits ? traits : &s_traitsConsole);

could work?

НУ> Next error
НУ> Error E2015 ..\..\src\common\filename.cpp 2589: Ambiguity between
НУ> 'wxFileName::Exists(int)
НУ> const at ..\..\src\common\filename.cpp:777' and 'wxFileName::Exists(const
НУ> wxString &,int)
НУ> at ..\..\src\common\filename.cpp:790' in function
НУ> wxFileName::SetPermissions(int)

Clear compiler bug as well :-( I guess adding an explicit "this->" before
Exists() call might fix it?

Regards,
VZ

[Никита Ушаков]

Post by Vadim Zeitlin
return *(traits ? traits : &s_traitsConsole);
could work?
Yes. Work.
НУ> Next error
Clear compiler bug as well :-( I guess adding an explicit "this->" before
Exists() call might fix it?

No, not corrected.
Stupid option
Exists(GetFullPath(), wxFILE_EXISTS_SYMLINK|wxFILE_EXISTS_NO_FOLLOW)

But then there are still bugs.
Horrible compiler.

[Никита Ушаков]

Error E2357 ..\..\include\wx/dcmirror.h 227: Reference initialized with 'const
wxPoint * const', needs lvalue of type 'const wxPoint *' in function
wxMirrorDCImpl::DoDrawLines(int,const wxPoint * const,int,int)
Error E2342 ..\..\include\wx/dcmirror.h 227: Type mismatch in parameter
'points' (wanted 'const wxPoint * &', got 'const wxPoint *') in function
wxMirrorDCImpl::DoDrawLines(int,const wxPoint * const,int,int)
Use the compiler switch -Vbr to allow this.
<http://docwiki.embarcadero.com/RADStudio/XE6/en/Stricter_C++_Compiler_-_Binding_of_References_and_Qualifiers>

Next
Error E2304 ..\..\src\generic\srchctlg.cpp 1225: Constant variable '_Stz'
must be initialized
I'm at a dead end

(OS: Win7 x64, C++Builder 2007)

[Никита Ушаков]

Post by Никита Ушаков
Next
Error E2304 ..\..\src\generic\srchctlg.cpp 1225: Constant variable '_Stz'
must be initialized
Compiling without -v succeeds. This is relevant because Boost uses the -v

option. QC Entry 63508
<http://edn.embarcadero.com/print/images/40822/Delphi_XE_and_CBuilder_XE_QC_Bug_Fix_List.pdf>
This is correct?

[Никита Ушаков]

Post by Никита Ушаков
Error E2304 ..\..\src\generic\srchctlg.cpp 1225: Constant variable '_Stz'

Post by Никита Ушаков
must be initialized
Compiling without -v succeeds. This is relevant because Boost uses the -v

option. QC Entry 63508
<http://edn.embarcadero.com/print/images/40822/Delphi_XE_and_CBuilder_XE_QC_Bug_Fix_List.pdf>
This is correct?

makefile.bcc :
!if "$(BUILD)" == "release" && "$(DEBUG_INFO)" == "default"
__DEBUGINFO = -v-
!endif
!if "$(DEBUG_INFO)" == "0"
__DEBUGINFO = -v-
!endif
No problem. I'm to make with DEBUG_INFO = 0

Linker error :
Error: Unresolved external '_IID_IFileDialog' referenced from C:\WXWIDGETS-
3.0.1
\BUILD\MSW\BCC_MSWUDDLL\COREDLL_DIRDLG.OBJ
Error: Unresolved external '_CLSID_FileOpenDialog' referenced from C:\
WXWIDGETS-
3.0.1\BUILD\MSW\BCC_MSWUDDLL\COREDLL_DIRDLG.OBJ

[Vadim Zeitlin]

On Thu, 25 Sep 2014 14:52:29 -0700 (PDT) НОкОта УшакПв wrote:

НУ> Linker error :
НУ> Error: Unresolved external '_IID_IFileDialog' referenced from C:\WXWIDGETS-
НУ> 3.0.1
НУ> \BUILD\MSW\BCC_MSWUDDLL\COREDLL_DIRDLG.OBJ
НУ> Error: Unresolved external '_CLSID_FileOpenDialog' referenced from C:\
НУ> WXWIDGETS-
НУ> 3.0.1\BUILD\MSW\BCC_MSWUDDLL\COREDLL_DIRDLG.OBJ

Hmm, either it has it in some library we're not linking with (try grepping
the directory containing its libraries for this symbol to find the one with
it) or it doesn't define it at all but still somehow defines
__IFileDialog_INTERFACE_DEFINED__ that we rely on to provide the definition
of IID_IFileDialog ourselves. If it's the latter, we need an explicit check
for Borland in src/msw/dirdlg.cpp.

Regards,
VZ

[Vadim Zeitlin]

On Thu, 25 Sep 2014 13:44:45 -0700 (PDT) НОкОта УшакПв wrote:

НУ> Error E2357 ..\..\include\wx/dcmirror.h 227: Reference initialized with 'const
НУ> wxPoint * const', needs lvalue of type 'const wxPoint *' in function
НУ> wxMirrorDCImpl::DoDrawLines(int,const wxPoint * const,int,int)
НУ> Error E2342 ..\..\include\wx/dcmirror.h 227: Type mismatch in parameter
НУ> 'points' (wanted 'const wxPoint * &', got 'const wxPoint *') in function
НУ> wxMirrorDCImpl::DoDrawLines(int,const wxPoint * const,int,int)
НУ> Use the compiler switch -Vbr to allow this.
НУ> <http://docwiki.embarcadero.com/RADStudio/XE6/en/Stricter_C++_Compiler_-_Binding_of_References_and_Qualifiers>

We could get rid of this by not modifying "points" in place and using
"points_alloc" in Mirror() caller. This should help this compiler and would
arguably make the code somewhat more clear, so I wouldn't be opposed to
changing it like this.

НУ> Next
НУ> Error E2304 ..\..\src\generic\srchctlg.cpp 1225: Constant variable '_Stz'
НУ> must be initialized
НУ> I'm at a dead end

Yes, this one is pretty mysterious... Sorry, I really don't know anything
Borland compiler, the last version I used was 5.5 in the last millennium.

But if you can manage to get it working, please do submit your patches via
Trac (as explained in http://trac.wxwidgets.org/wiki/HowToSubmitPatches),
I'm sure other Borland users would appreciate them.

Good luck,
VZ

[Никита Ушаков]

OS: WinXP x86, C++Builder XE2
config.bcc - default

1. Error E2352 ..\..\src\common\appbase.cpp 320
<https://groups.google.com/d/msg/wx-users/GYLPgvzc37I/eNIAbS1fXaYJ>
2. Error E2015 ..\..\src\common\filename.cpp 2589
<https://groups.google.com/d/msg/wx-users/GYLPgvzc37I/LFK6j_J326IJ>

Building wxWidgets complete.

Try to build samples\minimal :

Error wx.rc 12 11: Cannot open file: windows.h
This file is in path $(BCCDIR)\include\windows\sdk

Edit the samples\minimal\makefile.bcc (245) add -i$(BCCDIR)\include\windows\
sdk:

brcc32 -32 -r -fo$@ -i$(BCCDIR)\include -i$(BCCDIR)\include\windows\sdk
-d__WXMSW__ $(__WXUNIV_DEFINE_p_1) $(__DEBUG_DEFINE_p_1) $(
__NDEBUG_DEFINE_p_1) $(__EXCEPTIONS_DEFINE_p_1) $(__RTTI_DEFINE_p_1) $(
__THREAD_DEFINE_p_1) $(__UNICODE_DEFINE_p_1) $(__MSLU_DEFINE_p_1) -i$(
SETUPHDIR) -i.\..\..\include $(____CAIRO_INCLUDEDIR_FILENAMES_1_p) -i. $(
__DLLFLAG_p_1) -i.\..\..\samples -dNOPCH .\..\..\samples\sample.rc

Build complete.


If SHARED = 1

build the wxWidgets returns

ilink32 -Tpd -q -LC:\PROGRA~1\EMBARC~1\RADSTU~1\9.0\bin\..\lib -LC:\
PROGRA~1\EMBARC~1\RADSTU~1\9.0\bin\..\lib\psdk -v -L..\..\lib\bcc_dll
@MAKE0008.@@@
Error: Unresolved external 'wxString::length() const' referenced from C:\
WXWIDGETS-3.0.1\BUILD\MSW\BCC_MSWUDDLL\NETDLL_FTP.OBJ
Error: Unresolved external 'wxString::clear()' referenced from C:\WXWIDGETS-
3.0.1\BUILD\MSW\BCC_MSWUDDLL\NETDLL_FTP.OBJ
Error: Unable to perform link

[Vadim Zeitlin]

On Fri, 26 Sep 2014 03:55:08 -0700 (PDT) НОкОта УшакПв wrote:

НУ> OS: WinXP x86, C++Builder XE2
НУ> config.bcc - default
НУ>
НУ> 1. Error E2352 ..\..\src\common\appbase.cpp 320
НУ> <https://groups.google.com/d/msg/wx-users/GYLPgvzc37I/eNIAbS1fXaYJ>
НУ> 2. Error E2015 ..\..\src\common\filename.cpp 2589
НУ> <https://groups.google.com/d/msg/wx-users/GYLPgvzc37I/LFK6j_J326IJ>

Could you please make a (tested) patch with these changes so that I could
apply it with one simple command?

НУ> Building wxWidgets complete.
НУ>
НУ> Try to build samples\minimal :
НУ>
НУ> Error wx.rc 12 11: Cannot open file: windows.h
НУ> This file is in path $(BCCDIR)\include\windows\sdk
НУ>
НУ> Edit the samples\minimal\makefile.bcc (245) add -i$(BCCDIR)\include\windows\
НУ> sdk:

OK, I've updated build/bakefiles/common.bkl to add this directory for
Borland.

НУ> Build complete.

Does it run?

НУ> If SHARED = 1
НУ>
НУ> build the wxWidgets returns
НУ>
НУ> ilink32 -Tpd -q -LC:\PROGRA~1\EMBARC~1\RADSTU~1\9.0\bin\..\lib -LC:\
НУ> PROGRA~1\EMBARC~1\RADSTU~1\9.0\bin\..\lib\psdk -v -L..\..\lib\bcc_dll
НУ> @MAKE0008.@@@
НУ> Error: Unresolved external 'wxString::length() const' referenced from C:\
НУ> WXWIDGETS-3.0.1\BUILD\MSW\BCC_MSWUDDLL\NETDLL_FTP.OBJ

I don't know what is in MAKE0008.@@@, but it's supposed to link with the
base library, does it?

Regards,
VZ

[Никита Ушаков]

Post by Vadim Zeitlin
НУ> OS: WinXP x86, C++Builder XE2
НУ> config.bcc - default
НУ>
НУ> 1. Error E2352 ..\..\src\common\appbase.cpp 320
НУ> <https://groups.google.com/d/msg/wx-users/GYLPgvzc37I/eNIAbS1fXaYJ>
НУ> 2. Error E2015 ..\..\src\common\filename.cpp 2589
НУ> <https://groups.google.com/d/msg/wx-users/GYLPgvzc37I/LFK6j_J326IJ>
Could you please make a (tested) patch with these changes so that I could
apply it with one simple command?

I will try to deal with this and make, but I can not promise, it is rapidly.



НУ> Build complete.

Post by Vadim Zeitlin
Does it run?

Yes, but I build and run only minimal and widgets.
The rest is not checked. Maybe, samples of use NETDLL_FTP not building.


NB
for C++Builder 2007 question linking wxWidgets open.